Re: [PATCH 2/3] media: rcar-vin: Fix RAW8

[Niklas Söderlund]

Hi Tomi,

Thanks for your patch.

On 2025-03-24 13:48:53 +0200, Tomi Valkeinen wrote:
> On Gen4 we need to set VNMC's EXINF to a different value (1) than in
> Gen3 (0). Add a define for this, and set the bit for Gen4.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/platform/renesas/rcar-vin/rcar-dma.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> index 972ae2cb3314..53046614f7a1 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> @@ -94,6 +94,7 @@
>  #define VNMC_INF_YUV16		(5 << 16)
>  #define VNMC_INF_RGB888		(6 << 16)
>  #define VNMC_INF_RGB666		(7 << 16)
> +#define VNMC_EXINF_RAW8		(1 << 12) /* Gen4 specific */
>  #define VNMC_VUP		(1 << 10)
>  #define VNMC_IM_ODD		(0 << 3)
>  #define VNMC_IM_ODD_EVEN	(1 << 3)
> @@ -791,6 +792,8 @@ static int rvin_setup(struct rvin_dev *vin)
>  	case MEDIA_BUS_FMT_SRGGB8_1X8:
>  	case MEDIA_BUS_FMT_Y8_1X8:
>  		vnmc |= VNMC_INF_RAW8;
> +		if (vin->info->model == RCAR_GEN4)
> +			vnmc |= VNMC_EXINF_RAW8;

This is a partial fix for RAW8, but more was needed to capture it 
correctly. But that issue covers more then just RAW8, I will send a 
proper patch to fix that. For this patch,

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Tested-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

>  		break;
>  	case MEDIA_BUS_FMT_SBGGR10_1X10:
>  	case MEDIA_BUS_FMT_SGBRG10_1X10:
> 
> -- 
> 2.43.0
> 

-- 
Kind Regards,
Niklas Söderlund