Re: [PATCH 2/9] x86/nmi: Consolidate NMI panic variables

From: Huang, Kai
Date: Mon Mar 31 2025 - 18:43:16 EST


On Thu, 2025-03-27 at 23:46 +0000, Mehta, Sohil wrote:
> Commit feeaf5512947 ("x86: Move sysctls into arch/x86")

AFAICT the commit hash is wrong. It should be c305a4e98378.

> recently moved the sysctl handling of panic_on_unrecovered_nmi and
> panic_on_io_nmi to x86-specific code. These variables no longer need to
> be declared in the generic header file.
>
> Relocate the variable definitions and declarations closer to where they
> are used. This makes all the NMI panic options consistent and easier to
> track.
>
> Signed-off-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>

Reviewed-by: Kai Huang <kai.huang@xxxxxxxxx>