Re: [PATCH 1/9] x86/nmi: Simplify unknown NMI panic handling

[Sohil Mehta]

On 3/31/2025 3:52 PM, Huang, Kai wrote:

>> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
>> index c7164a8de983..c3e1ae7373e9 100644
>> --- a/arch/x86/kernel/setup.c
>> +++ b/arch/x86/kernel/setup.c
>> @@ -7,10 +7,11 @@
>>   */
>>  #include <linux/acpi.h>
>>  #include <linux/console.h>
>> -#include <linux/cpu.h>
>>  #include <linux/crash_dump.h>
>> +#include <linux/cpu.h>
> 
> This code change doesn't seem to be able to make the headers in "alphabetical
> order".
> 

Ah! Thanks for catching it.


>>  
>>  #include <asm/apic.h>
>> -#include <asm/efi.h>
> 
> Seems this header just got removed here but was never added back.
> 

<asm/efi.h> is included twice. Therefore, the diff only shows it being
removed.

>> -#include <asm/numa.h>
>>  #include <asm/bios_ebda.h>
>>  #include <asm/bugs.h>
>>  #include <asm/cacheinfo.h>

Thanks,
Sohil