Re: [greybus-dev] Re: [PATCH] staging: greybus: Multiple cleanups and refactors
From: Jeff Johnson
Date: Mon Mar 31 2025 - 20:17:46 EST
On 3/31/2025 5:03 PM, Ganesh Kumar Pittala wrote:
> Hi Alex,
>
> Thank you for the detailed feedback and guidance. I appreciate your time
> reviewing the patch.
>
> I’ll split the changes into separate patches as suggested and send a v2 shortly.
>
> Best regards,
> Ganesh Pittala
Some more feedback:
Don't "top post"
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions
Also don't use HTML e-mail
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
Yes, there are a lot of hoops you have to jump through to get your code in the
kernel. It becomes easier over time.
/jeff