Re: [PATCH 2/9] x86/nmi: Consolidate NMI panic variables

[Huang, Kai]

On Mon, 2025-03-31 at 16:20 -0700, Mehta, Sohil wrote:
> On 3/31/2025 4:05 PM, Huang, Kai wrote:
> > On Mon, 2025-03-31 at 15:50 -0700, Mehta, Sohil wrote:
> > > On 3/31/2025 3:43 PM, Huang, Kai wrote:
> > > > On Thu, 2025-03-27 at 23:46 +0000, Mehta, Sohil wrote:
> > > > > Commit feeaf5512947 ("x86: Move sysctls into arch/x86")
> > > > 
> > > > AFAICT the commit hash is wrong.  It should be c305a4e98378.
> > > > 
> > > 
> > > Yes, sorry about that. I ended up referencing a pre-merge duplicate
> > > commit in my repo.
> > > 
> > > Thankfully, Ingo fixed it when he applied the patch:
> > > https://web.git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/nmi&id=1a5b15f6b4d18507dc3b2958ca01877cfc8808fd
> > > 
> > > 
> > 
> > Ah I didn't know this series was merged.  I think I'll stop looking at it.  :-)
> 
> Your review comments have been useful. Please continue reviewing if you
> can. You found an issue in patch 1 that both of us missed.
> 

I just did.  I didn't find anything apart from one thing that I _think_ it might
be helpful to mention another commit in the changelog of patch 5 "x86/nmi: Fix
comment in unknown NMI handling".

Thanks.