Re: [PATCH] coresight: fix the wrong type of the trace_id in coresight_path

From: Anshuman Khandual
Date: Tue Apr 01 2025 - 02:11:21 EST


On 4/1/25 07:12, Jie Gan wrote:
> The trace_id in coresight_path may contain an error number which means a
> negative integer, but the current type of the trace_id is u8. Change the
> type to int to fix it.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Fixes: 3c03c49b2fa5 ("Coresight: Introduce a new struct coresight_path")
> Signed-off-by: Jie Gan <jie.gan@xxxxxxxxxxxxxxxx>

LGTM

Reviewed-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>

> ---
> include/linux/coresight.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index d79a242b271d..c2bf10c43e7c 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -337,7 +337,7 @@ static struct coresight_dev_list (var) = { \
> */
> struct coresight_path {
> struct list_head path_list;
> - u8 trace_id;
> + int trace_id;
> };
>
> enum cs_mode {