Re: [PATCH] arm64: Don't call NULL in do_compat_alignment_fixup

From: Angelos Oikonomopoulos
Date: Tue Apr 01 2025 - 04:59:25 EST


On Tue Apr 1, 2025 at 10:22 AM CEST, Anshuman Khandual wrote:
> Makes sense. A small nit - just wondering if the following restructuring
> here would make things bit more readable ? Regardless, your decision.
>
> if (handler)
> type = handler(addr, instr, regs);
> else
> return 1;

I went with the original formulation since -- to my mind at least -- an
"early exit" idiom feels more appropriate for something we found we
can't handle. Could work either way though.

Thanks,
Angelos