Re: [PATCH 4/4] arm64: dts: renesas: r8a779g3: Add Renesas R-Car V4H Sparrow Hawk board support

[Geert Uytterhoeven]

Hi Marek,

Thanks for your patch!

On Sun, 30 Mar 2025 at 21:58, Marek Vasut
<marek.vasut+renesas@xxxxxxxxxxx> wrote:
> Add Renesas R-Car V4H Sparrow Hawk board based on R-Car V4H ES3.0 (R8A779G3)

Retronix

> SoC. This is a single-board computer with single gigabit ethernet, DSI-to-eDP
> bridge, DSI and two CSI2 interfaces, audio codec, two CANFD ports, micro SD
> card slot, USB PD supply, USB 3.0 ports, M.2 Key-M slot for NVMe SSD, debug
> UART and JTAG.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>

> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts
> @@ -0,0 +1,671 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +/*
> + * Device Tree Source for the R-Car V4H ES3.0 Sparrow Hawk board
> + *
> + * Copyright (C) 2025 Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> + */
> +
> +/dts-v1/;
> +#include <dt-bindings/gpio/gpio.h>
> +
> +#include "r8a779g3.dtsi"
> +
> +/ {
> +       model = "Retronix Sparrow Hawk board based on r8a779g3";
> +       compatible = "retronix,sparrow-hawk", "renesas,r8a779g3",
> +                    "renesas,r8a779g0";
> +
> +       aliases {
> +               ethernet0 = &avb0;
> +               i2c0 = &i2c0;
> +               i2c1 = &i2c1;
> +               i2c2 = &i2c2;
> +               i2c3 = &i2c3;
> +               i2c4 = &i2c4;
> +               i2c5 = &i2c5;
> +               serial0 = &hscif0;

This assumes HSCIF0 is the main console.

As you also have a second debug console on USB:

    serial1 = &hscif1;

And the serial port on the RPI I/O connector:

    serial2 = &hscif3;

> +               spi0 = &rpc;

Do you need the spi0 alias?

> +&pfc {
> +       pinctrl-0 = <&scif_clk_pins>;
> +       pinctrl-names = "default";
> +
> +       /* Page 22 / Ether_AVB0 */
> +       avb0_pins: avb0 {
> +               mux {
> +                       groups = "avb0_link", "avb0_mdio", "avb0_rgmii",
> +                                "avb0_txcrefclk";
> +                       function = "avb0";
> +               };
> +
> +               pins_mdio {

Please no underscores in node names (everywhere).

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds