Re: [PATCH] fs: remove stale log entries from fs/namei.c

[Mateusz Guzik]

On Tue, Apr 1, 2025 at 12:49 PM Christian Brauner <brauner@xxxxxxxxxx> wrote:
>
> On Tue, 01 Apr 2025 07:08:46 +0200, Mateusz Guzik wrote:
> >
>
> I have zero attachment to these comments so I'm inclined to agree and
> remove them. Please anyone who really really thinks we need them speak
> up!

ouch man

this submission was a joke, which is why I only sent it to the list
and skipped the maintainers as direct recipients

it *adds* the following:
>  /*[Apr 1 2024 Mateusz Guzik] Removed stale log entries.

I can't tell if this actually landed because the url:
> [1/1] fs: remove stale log entries from fs/namei.c
>       https://git.kernel.org/vfs/vfs/c/3dddecbd2b47

says "bad object id" at the moment.

I very much support removal of this kind of commentary, but this could
be very flamewar inducing and I did not want to spend time on a
non-tech discussion about it.

However, if actually doing this, there is more to whack and I'll be
happy to do a real submission with more files.

Even in this file alone:
> /* In order to reduce some races, while at the same time doing additional
> * checking and hopefully speeding things up, we copy filenames to the
> * kernel data space before using them..

I think this comment also needs to get whacked. Copying the path is
not optional.

-- 
Mateusz Guzik <mjguzik gmail.com>