Aw: Re: [PATCH] arm64: dts: mediatek: mt7988a-bpi-r4: allow hw variants of bpi-r4

[Frank Wunderlich]

Hi

how to proceed here?

> Gesendet: Montag, 10. Februar 2025 um 12:18
> Von: "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>
>
> Am 10. Februar 2025 11:56:40 MEZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>:
> >Il 07/02/25 14:54, Frank Wunderlich ha scritto:
> >> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> >>
> >> Sinovoip has released other variants of Bananapi-R4 board.
> >> The known changes affecting only the LAN SFP+ slot which is replaced
> >> by a 2.5G phy with optional PoE.
> >>
> >> As the SFP-Ports are not upstreamed yet this patch simply renames the
> >> current board dts to dtsi, creating new dts for the board including
> >> the new dtsi and move i2c-mux channel for sfp lan to board dts.
> >>
> >> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> >
> >I understand what's going on, and I agree, but this change alone doesn't make a lot
> >of sense, does it?
> >
> >If I were to see a commit that moves everything in a dtsi, and justifies that by
> >adding two dts for the two variants, though, things would be different.... :-)

what is the difference to this commit (imho it does basicly the same for other SoC)?

73955991b8fb 2025-02-06 arm64: dts: mediatek: mt8390-genio-700-evk: Move common parts to dtsi
arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts
arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi

> >> ---
> >>   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts  | 404 +-----------------
> >>   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi | 403 +++++++++++++++++
> >>   2 files changed, 407 insertions(+), 400 deletions(-)
> >>   create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi
> >>
>
> It is preparation for adding additional nodes like sfp cages. I only have the dual-sfp board so i can only add these based on schematic. The one (wan-sfp) would go into dtsi and lan-sfp go into dts because other variants using a phy here as described.

regards Frank