Re: [PATCH 0/5] Improve WARN_ON_ONCE() output by adding the condition string

[Rasmus Villemoes]

On Wed, Mar 26 2025, Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> The cost is about +100K more .data on a defconfig kernel, and no runtime
> code generation impact:
>
>        text       data        bss         dec        hex    filename
>    29523998    7926322    1389904    38840224    250a7a0    vmlinux.x86.defconfig.before
>    29523998    8024626    1389904    38938528    25227a0    vmlinue.x86.defconfig.after
>

That's quite a lot. I don't suppose the condition strings themselves are
responsible for most of that; how much is due to the __FILE__ strings
now no longer being deduplicated/shared between WARN instances in same
file? How much harder would it be to add a new cond_str member to
bug_entry, and how would the numbers look then?

Rasmus