Re: [PATCH v1 4/6] dt-bindings: arm: qcom: Add Asus Zenbook A14

[Krzysztof Kozlowski]

On 01/04/2025 12:16, Aleksandrs Vinarskis wrote:
> On Tue, 1 Apr 2025 at 07:38, Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> On 31/03/2025 23:53, Aleksandrs Vinarskis wrote:
>>> Document the X1E-78-100 and X1P-42-100/X1-26-100 variants.
>>>
>>> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@xxxxxxxxx>
>>> ---
>>>  Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> index 08c329b1e919..1b7e2ed56baa 100644
>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> @@ -1133,6 +1133,7 @@ properties:
>>>        - items:
>>>            - enum:
>>>                - asus,vivobook-s15
>>> +              - asus,x1e80100-zenbook-a14
>>
>> asus,zenbook-a14-x1e80100
>>
>> asus did not make a component of x1e80100 soc.
> 
> I see, I misunderstood the meaning of qcom,x1e80100-crd, clear now.
> In that case, perhaps follow pattern of other devices, describe by

Qualcomm dev boards follow such pattern, even though actual name is for
example mtp8750.

> model differences (eg. -oled) instead of soc? eg:
> 
> `asus,zenbook-a14-ux3407ra` (for x1e variant)
> `asus,zenbook-a14-ux3407qa` (for x1/x1p variants)

I am fine with both, just wanted the actual generic/common product name
first.

> 
> Thanks for the review,
> Alex
> 
>>
>>>                - dell,xps13-9345
>>>                - hp,omnibook-x14
>>>                - lenovo,yoga-slim7x
>>> @@ -1144,6 +1145,7 @@ properties:
>>>
>>>        - items:
>>>            - enum:
>>> +              - asus,x1p42100-zenbook-a14
>>
>> Same here.
>>
>>
>> Best regards,
>> Krzysztof


Best regards,
Krzysztof