Re: [PATCH v5 06/13] scripts: generate_rust_analyzer.py: add type hints

From: Daniel Almeida
Date: Tue Apr 01 2025 - 09:02:13 EST


Hi Tamir,

>>
>> I found `args_crates_cfgs()` a lot easier to understand, but I guess this is a
>> matter of taste. I also find that this `defaultdict()` call slightly pollutes
>> the surrounding code, but again, that might be just me.
>
> Would extracting a local variable suffice?
>

Yeah, that would make it less crowded.

— Daniel