Re: [PATCH v2 3/7] mm/gup: Fix the outdated code comments above get_user_pages_unlocked()

[Oscar Salvador]

On Mon, Mar 31, 2025 at 04:13:23PM +0800, Baoquan He wrote:
> Since commit f0818f472d8d ("mm: gup: add get_user_pages_locked
> and get_user_pages_unlocked"), get_user_pages() doesn't need to have
> mmap_lock held anymore. It calls __get_user_pages_locked() which
> can acquire and drop the mmap_lock internaly.
> 
> Hence remove the incorrect code comments now.

Uhm, I think this one should be dropped according to 

https://lore.kernel.org/linux-mm/20250330121718.175815-4-bhe@xxxxxxxxxx/T/#m1aa161016ab98a6d85bcb657a729e01cb98763ec

?


-- 
Oscar Salvador
SUSE Labs