Re: [PATCH v2 4/7] mm/gup: remove gup_fast_pgd_leaf() and clean up the relevant codes

From: Oscar Salvador
Date: Tue Apr 01 2025 - 10:13:07 EST


On Mon, Mar 31, 2025 at 04:13:24PM +0800, Baoquan He wrote:
> In the current kernel, only pud huge page is supported in some
> architectures. P4d and pgd huge pages haven't been supported yet.
> And in mm/gup.c, there's no pgd huge page handling in the
> follow_page_mask() code path. Hence it doesn't make sense to have
> gup_fast_pgd_leaf() in gup_fast code path.
>
> Here remove gup_fast_pgd_leaf() and clean up the relevant codes.
>
> Signed-off-by: Baoquan He <bhe@xxxxxxxxxx>

Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>



--
Oscar Salvador
SUSE Labs