Re: [PATCH v3 1/3] dt-bindings: leds: Add LP5812 LED driver

[Nam Tran]

On Mon, 31 Mar 2025, Krzysztof Kozlowski wrote:

>Please do not explain me how DT works, we all know. You do not have
>child node. If you disagree - point me to the line in schema having it.

Thank you for your feedback.
I now understand that my schema does not define child nodes, so #address-cells and #size-cells should not be included.
I will update the schema accordingly as shown below.

# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/leds/ti,lp5812.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: TI/National Semiconductor LP5812 LED Driver

maintainers:
  - Nam Tran <trannamatk@xxxxxxxxx>

description: |
  The LP5812 is an I2C LED Driver that can support LED matrix 4x3.
  For more product information please see the link below:
  https://www.ti.com/product/LP5812#tech-docs

properties:
  compatible:
    const: ti,lp5812

  reg:
    maxItems: 1
    description:
      I2C slave address
      lp5812/12- 0x1b

patternProperties:
  "^led@[0-9a-b]$":
    type: object
    $ref: common.yaml#
    unevaluatedProperties: false

    properties:
      reg:
        minimum: 0
        maximum: 0xb

      chan-name:
        $ref: /schemas/types.yaml#/definitions/string
        description: LED channel name

    required:
      - reg

required:
  - compatible
  - reg

additionalProperties: false

examples:
  - |
    #include <dt-bindings/leds/common.h>

    i2c {
        #address-cells = <1>;
        #size-cells = <0>;

        led-controller@1b {
            compatible = "ti,lp5812";
            reg = <0x1b>;

            led@0 {
                    reg = <0x0>;
                    chan-name = "a0";
            };
            led@1 {
                    reg = <0x1>;
                    chan-name = "a1";
            };
            led@2 {
                    reg = <0x2>;
                    chan-name = "a2";
            };
            led@3 {
                    reg = <0x3>;
                    chan-name = "b0";
            };
            led@4 {
                    reg = <0x4>;
                    chan-name = "b1";
            };
            led@5 {
                    reg = <0x5>;
                    chan-name = "b2";
            };
            led@6 {
                    reg = <0x6>;
                    chan-name = "c0";
            };
            led@7 {
                    reg = <0x7>;
                    chan-name = "c1";
            };
            led@8 {
                    reg = <0x8>;
                    chan-name = "c2";
            };
            led@9 {
                    reg = <0x9>;
                    chan-name = "d0";
            };
            led@a {
                    reg = <0xa>;
                    chan-name = "d1";
            };
            led@b {
                    reg = <0xb>;
                    chan-name = "d2";
            };
        };
    };

...


Best regards,
Nam Tran