Re: [PATCH -v2 00/49] Simplify, reorganize and clean up the x86 text-patching code (alternative.c)

From: Peter Zijlstra
Date: Tue Apr 01 2025 - 10:31:51 EST


On Fri, Mar 28, 2025 at 02:26:15PM +0100, Ingo Molnar wrote:
> This series has 3 main parts:
>
> (1)
>
> The first part of this series performs a thorough text-patching API namespace
> cleanup discussed with Linus for the -v1 series:
>
> # boot/UP APIs & single-thread helpers:
>
> text_poke()
> text_poke_kgdb()
> [ unchanged APIs: ] text_poke_copy()
> text_poke_copy_locked()
> text_poke_set()
>
> text_poke_addr()
>
> # SMP API & helpers namespace:
>
> text_poke_bp() => smp_text_poke_single()
> text_poke_loc_init() => __smp_text_poke_batch_add()
> text_poke_queue() => smp_text_poke_batch_add()
> text_poke_finish() => smp_text_poke_batch_finish()
>
> text_poke_flush() => [removed]
>
> text_poke_bp_batch() => smp_text_poke_batch_process()
> poke_int3_handler() => smp_text_poke_int3_trap_handler()
> text_poke_sync() => smp_text_poke_sync_each_cpu()
>

Not sure I like that; smp_text_poke_ is a bit of a mouth full, esp. if
you're then adding even more text.

Do we really need function names this long?