Re: [PATCH v3 3/7] firmware: arm_scmi: imx: Add i.MX95 LMM protocol

From: Sudeep Holla
Date: Tue Apr 01 2025 - 10:48:38 EST


On Tue, Apr 01, 2025 at 03:36:31PM +0100, Cristian Marussi wrote:
> On Tue, Apr 01, 2025 at 03:21:51PM +0100, Sudeep Holla wrote:
> > On Mon, Mar 03, 2025 at 10:53:24AM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > >
> > > Add Logical Machine Management(LMM) protocol which is intended for boot,
> > > shutdown, and reset of other logical machines (LM). It is usually used to
> > > allow one LM to manager another used as an offload or accelerator engine.
> > >
> >
> > This and next patch LGTM. Just curious as why Cristian has given tags only
> > for the drivers using these but not these changes.
> >
> > Cristian, any specific concerns you had that had to be addressed or addressed
> > in this version ?
>
> I think I had some review comments on the previous version of this
> series for Documentation and protocol....let me see wth I said about
> this :D and if they have been addressed...
>

Thanks that would be great. I can't recall which version I had a look,
hence thought of asking.

--
Regards,
Sudeep