Re: [PATCH bpf] bpf: add missing ops lock around dev_xdp_attach_link

From: Alexei Starovoitov
Date: Tue Apr 01 2025 - 11:07:04 EST


On Tue, Apr 1, 2025 at 3:33 AM Paolo Abeni <pabeni@xxxxxxxxxx> wrote:
>
> On 3/31/25 4:28 PM, Stanislav Fomichev wrote:
> > Syzkaller points out that create_link path doesn't grab ops lock,
> > add it.
> >
> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> > Reported-by: syzbot+08936936fe8132f91f1a@xxxxxxxxxxxxxxxxxxxxxxxxx
> > Closes: https://lore.kernel.org/bpf/67e6b3e8.050a0220.2f068f.0079.GAE@xxxxxxxxxx/
> > Fixes: 97246d6d21c2 ("net: hold netdev instance lock during ndo_bpf")
> > Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxxx>
>
> LGTM, but are there any special reasons to get this via the bpf tree? It
> looks like 'net' material to me?!?

Pls take it through net.