Re: [PATCH v2 05/15] dt-bindings: display: mediatek: add OUTPROC yaml for MT8196

[Paul-pl Chen (陳柏霖)]

On Mon, 2025-03-24 at 11:02 -0500, Rob Herring wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Fri, Mar 21, 2025 at 05:33:34PM +0800, paul-pl.chen wrote:
> > From: Paul-pl Chen <paul-pl.chen@xxxxxxxxxxxx>
> > 
> > Add mediate,outproc.yaml to support OUTPROC for MT8196.
> > MediaTek display overlap output processor, namely OVL_OUTPROC
> > or OUTPROC,handles the post-stage of pixel processing in the
> > overlapping procedure.
> > 
> > Signed-off-by: Paul-pl Chen <paul-pl.chen@xxxxxxxxxxxx>
> > ---
> >  .../display/mediatek/mediatek,outproc.yaml    | 54
> > +++++++++++++++++++
> >  1 file changed, 54 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/mediatek/mediatek,outproc
> > .yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,outpr
> > oc.yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,outpr
> > oc.yaml
> > new file mode 100644
> > index 000000000000..f42e9abc1436
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,outpr
> > oc.yaml
> > @@ -0,0 +1,54 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/display/mediatek/mediatek,outproc.yaml*__;Iw!!CTRNKA9wMg0ARbw!ghGkyCSu5Imt_Qeb1RI5QcLmLfa_Q1aEayGOzR2CJs_yks_d7KvxS3HLH_e6SVWf4bq8iEm8gKfVhyPozw$
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!ghGkyCSu5Imt_Qeb1RI5QcLmLfa_Q1aEayGOzR2CJs_yks_d7KvxS3HLH_e6SVWf4bq8iEm8gKfoJ-K_hA$
> > +
> > +title: MediaTek display overlap output processor
> > +
> > +maintainers:
> > +  - Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx>
> > +  - Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > +
> > +description: |
> 
> Don't need '|' if no formatting to preserve.
Sure, I will remove this part.

> 
> > +  MediaTek display overlap output processor, namely OVL_OUTPROC or
> > OUTPROC,
> > +  handles the post-stage of pixel processing in the overlapping
> > procedure.
> > +  OVL_OUTPROC manages pixels for gamma correction and ensures that
> > pixel
> > +  values are within the correct range.
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt8196-outproc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        disp_ovl0_outproc0: outproc@32970000 {
> 
> Drop unused labels.
Sure, we will remove the unused labels. "disp_ovl0_outproc0"

Best regards, 

Paul
> 
> > +            compatible = "mediatek,mt8196-outproc";
> > +            reg = <0 0x32970000 0 0x1000>;
> > +            clocks = <&ovlsys_config_clk 49>;
> > +            interrupts = <GIC_SPI 450 IRQ_TYPE_LEVEL_HIGH 0>;
> > +        };
> > +    };
> > --
> > 2.45.2
> >