RE: [PATCH] i2c: rzv2m: Constify struct i2c_algorithm

[Fabrizio Castro]

> From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Sent: 29 March 2025 14:37
> Subject: [PATCH] i2c: rzv2m: Constify struct i2c_algorithm
> 
> 'struct i2c_algorithm' is not modified in this driver.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>   11027	    646	     16	  11689	   2da9	drivers/i2c/busses/i2c-rzv2m.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   11107	    566	     16	  11689	   2da9	drivers/i2c/busses/i2c-rzv2m.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>

> ---
> Compile tested-only.
> ---
>  drivers/i2c/busses/i2c-rzv2m.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-rzv2m.c b/drivers/i2c/busses/i2c-rzv2m.c
> index 53762cc56d28..b0e9c0b62429 100644
> --- a/drivers/i2c/busses/i2c-rzv2m.c
> +++ b/drivers/i2c/busses/i2c-rzv2m.c
> @@ -402,7 +402,7 @@ static const struct i2c_adapter_quirks rzv2m_i2c_quirks = {
>  	.flags = I2C_AQ_NO_ZERO_LEN,
>  };
> 
> -static struct i2c_algorithm rzv2m_i2c_algo = {
> +static const struct i2c_algorithm rzv2m_i2c_algo = {
>  	.xfer = rzv2m_i2c_xfer,
>  	.functionality = rzv2m_i2c_func,
>  };
> --
> 2.49.0