Re: [PATCH v4 8/8] x86/fpu/xstate: Warn if guest-only supervisor states are detected in normal fpstate

From: Chang S. Bae
Date: Tue Apr 01 2025 - 13:19:17 EST


On 3/18/2025 8:31 AM, Chao Gao wrote:
+ WARN_ON_FPU(!fpstate->is_guest && (mask & XFEATURE_MASK_SUPERVISOR_GUEST));

Did you check xfeatures_mask_supervisor()? I think you might want to introduce a similar wrapper to reference the enabled features (max_features) here.

Also, have you audited other code paths to ensure that no additional guard like this is needed? Can you summarize your audit process?

Thanks,
Chang