Re: [PATCH] locking/local_lock, mm: Replace localtry_ helpers with local_trylock_t type

From: Alexei Starovoitov
Date: Tue Apr 01 2025 - 16:56:15 EST


On Tue, Apr 1, 2025 at 7:18 AM Vlastimil Babka <vbabka@xxxxxxx> wrote:
>
> > with newly introduced local_trylock_t type.
> > Note that attempt to use local_trylock_irqsave() with local_lock_t
> > will cause compilation failure.
> >
> > Usage and behavior in !PREEMPT_RT:
> >
> > local_lock_t lock; // sizeof(lock) == 0
>
> local_lock(&lock, ...); // preempt disable

changed to local_lock(&lock);

>
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
>
> Is there a chance this refactoring will make it to -rc1? It would make
> basing the further usage of the lock in mm and slab trees much easier.

+1

> But squash in the following fixups please:

Thanks a bunch. Folded.

And sent v2:
https://lore.kernel.org/bpf/20250401205245.70838-1-alexei.starovoitov@xxxxxxxxx/

As soon as Sebastian acks it, I can send bpf PR with these 3 fixes
and other bpf fixes.