Re: [PATCH v1 1/1] nvme: add admin controller support. prohibit ioq creation for admin & disco ctrlrs

[Kamaljit Singh]

Hi Niklas,

On 2025/03/31 00:25, Niklas Cassel wrote:

>Like Damien said,
>
>> Added capability to connect to an administrative controller by
>> preventing ioq creation for admin-controllers.
>
>patch 2/4,
>I think I deserve:
>Suggested-by: Niklas Cassel <cassel@xxxxxxxxxx>
>
>on this patch.
You sure do. I wasn't aware of this designation. I'll add it. Thanks for
all your help.


>> * Renamed nvme_discovery_ctrl() to nvmf_discovery_ctrl() as discovery is
>>   more relevant to fabrics
>
>patch 1/4, you need to move the function, but can keep the name.
Like I replied to Damien, I wasn't able to easily move these to host/nvme.h
so they're in core.c.

I'll separate into patches as you suggested.

Thanks,
Kamaljit