Re: [PATCH 0/2] TDX attestation support
From: Edgecombe, Rick P
Date: Tue Apr 01 2025 - 20:20:29 EST
On Wed, 2025-04-02 at 08:15 +0800, Binbin Wu wrote:
> Opens
> =====
> Linux TDX guests don't use SetupEventNotifyInterrupt for TD attestation
> currently. If no other TDX guests use it, the support for
> SetupEventNotifyInterrupt could be dropped. But it would require an opt-in
> if the support is added later.
I think we shouldn't be afraid of opt-ins. We will need one sooner or later.
Better to not add the second exit with no users.
>
> In this patch series, KVM does sanity checks for the TDVMCALLs so that
> different userspace VMMs can save the code for sanity checks. But it could
> be dropped if it's preferred to keep KVM code simpler and let the userspace
> VMMs take the responsibility.
I say we push it to userspace to keep KVM as small as possible.