Re: [PATCH] tty: serial: samsung: Fix potential buffer overflow in clkname

From: Jiri Slaby
Date: Wed Apr 02 2025 - 00:44:31 EST


FWIW Your e-mail client broke threading.

On 02. 04. 25, 3:33, jiang.peng9@xxxxxxxxxx wrote:
Same comments as with other patches, not possible, IMO. Plus this patch
looks actually worse - commit msg is hardly readable.

Best regards,
Krzysztof

Hi Krzysztof,
Thank you for your feedback. Let me briefly re-explain the change:
The issue:
When building with W=1, we get a format-overflow warning because "clk_uart_baud%d" could write 15-17 bytes (14 chars + 1-3 digits) into a 15-byte buffer.

Hi,

how did you come to "1-3 digits"?

thanks,
--
js
suse labs