RE: [PATCH v14 4/6] firmware: imx: add driver for NXP EdgeLock Enclave

[Pankaj Gupta]

>> diff --git a/drivers/firmware/imx/se_ctrl.h 
>> b/drivers/firmware/imx/se_ctrl.h new file mode 100644 index 
>> 000000000000..177623f3890e
>> --- /dev/null
>> +++ b/drivers/firmware/imx/se_ctrl.h
>> @@ -0,0 +1,84 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ */
>> +/*
>> + * Copyright 2025 NXP
>> + */
>> +
>> +#ifndef SE_MU_H
>> +#define SE_MU_H
>> +
>> +#include <linux/miscdevice.h>
>> +#include <linux/semaphore.h>
>> +#include <linux/mailbox_client.h>
>> +

....

>> +};
>> +
>> +struct se_if_defines {
>> +	const u8 se_if_type;
>> +	const u8 se_instance_id;
Getting used at drivers/firmware/imx/se_ctrl.c:320

> This is not used actually, you can remove it
Getting used at drivers/firmware/imx/se_ctrl.c:347

>> +	u8 cmd_tag;
>> +	u8 rsp_tag;
>> +	u8 success_tag;
>> +	u8 base_api_ver;
>> +	u8 fw_api_ver;
>> +};
>> +
>> +struct se_if_priv {
>> +	struct device *dev;
>> +

Attachment: smime.p7s
Description: S/MIME cryptographic signature