Re: [PATCH 0/2] PCI: Remove pcim_iounmap_regions()

From: Philipp Stanner
Date: Wed Apr 02 2025 - 03:59:08 EST


On Thu, 2025-03-27 at 13:42 +0200, Andy Shevchenko wrote:
> On Thu, Mar 27, 2025 at 12:07:06PM +0100, Philipp Stanner wrote:
> > The last remaining user of pcim_iounmap_regions() is mtip32 (in
> > Linus's
> > current master)
> >
> > So we could finally remove this deprecated API. I suggest that this
> > gets
> > merged through the PCI tree.
>
> Good god! One API less, +1 to support this move.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> > (I also suggest we watch with an eagle's
> > eyes for folks who want to re-add calls to that function before the
> > next
> > merge window opens).
>
> Instead of this I suggest that PCI can take this before merge window
> finishes
> and cooks the (second) PR with it. In such a case we wouldn't need to
> care,
> the developers will got broken builds.
>

Normally Bjorn / PCI lets changes settle on a branch for >1 week before
throwing them at mainline – but if we ask him very very nicely, maybe
he would make an exception for this special case? :)

P.