Re: [PATCH 2/2] fuse: Adjust readdir() buffer to requesting buffer size.

From: Miklos Szeredi
Date: Wed Apr 02 2025 - 04:18:53 EST


On Wed, 2 Apr 2025 at 09:55, Jaco Kroon <jaco@xxxxxxxxx> wrote:
>
> Hi,
>
> I can definitely build on that, thank you.
>
> What's the advantage of kvmalloc over folio's here, why should it be
> preferred?

It offers the best of both worlds: first tries plain malloc (which
just does a folio alloc internally for size > PAGE_SIZE) and if that
fails, falls back to vmalloc, which should always succeed since it
uses order 0 pages.

This saves the trouble of iterating the folio alloc until it succeeds,
which is both undeterministic and complex, neither of which is
desirable.

Thanks,
Miklos