Re: [PATCH 1/1] genirq/msi: Dynamic remove/add stroage adapter hits EEH

From: Thomas Gleixner
Date: Wed Apr 02 2025 - 04:33:20 EST


On Tue, Apr 01 2025 at 15:14, Wen Xiong wrote:
> On 2025-03-28 06:27, Thomas Gleixner wrote:
>
>> You are completely missing the point. This is not a problem restricted
>> to PCI/MSI interrupts.
>>
> Thanks for all suggestions! I will investigate more and check if we can
> fix it in device driver.
>
> Looks several device drivers in kernel use two kernel APIs to set/clean
> IRQ_NO_BALACING status for a given irq.
>
> irq_set_status_flags(irq, IRQ_NO_BALANCING);
> irq_clear_status_flags(irq, IRQ_NO_BALANCING);
>
> With these two APIs, device driver can decide if using kernel irq
> balance or setting irq affinity by driver itself?
>
> So we can set/clear IRQ_NO_BALANCING during reset.

That's not sufficient. You are papering over the symptom. I explained
you that affinity setting is not the only way to wreckage this.

But feel free to ignore me and apply your bandaid fix as you see fit.

Thanks,

tglx