Re: [PATCH] rust: clean Rust 1.86.0 new `clippy::needless_continue` cases
From: Miguel Ojeda
Date: Wed Apr 02 2025 - 07:14:16 EST
On Wed, Apr 2, 2025 at 1:53 AM Benno Lossin <benno.lossin@xxxxxxxxx> wrote:
>
> I'm not too sure about this change, if the loop is longer than one
> screen, it makes a lot of sense to have a `continue` instead of `()`,
> since one might not see that there is nothing after the `match`.
>
> I also think that an explicit `continue` is nicer from a expressability
> standpoint. So I think we should keep them.
Yeah, I feel similarly. It is sad because the lint did find other
cases in the past that were useful.
If nobody else cares about keeping this one enabled, then I will send
the alternative patch. Hopefully we can re-enable it at some point in
the future.
Cheers,
Miguel