Re: [PATCH net-next 6/9] net: ethernet: ti: cpsw_ale: add cpsw_ale_policer_set/clr_entry()

[Roger Quadros]

On 25/03/2025 16:21, Jakub Kicinski wrote:
> On Wed, 19 Mar 2025 15:38:32 +0200 Roger Quadros wrote:
>> +/* FIXME: VLAN ID based flow routing not yet working, Only PCP matching for now
>> + *		u32 port_mask, unreg_mcast = 0;
>> + *
>> + *		port_mask = BIT(cfg->port_id) | ALE_PORT_HOST;
>> + *		if (!cfg->vid)
>> + *			unreg_mcast = port_mask;
>> + *		ale_idx = cpsw_ale_vlan_add_modify(ale, cfg->vid, port_mask,
>> + *				unreg_mcast, port_mask, 0);
>> + *		if (ale_idx < 0)
>> + *			return -ENOENT;
>> + *
>> + *		regmap_field_write(ale->fields[POL_OVLAN_INDEX], ale_idx);
>> + *		regmap_field_write(ale->fields[POL_OVLAN_MEN], 1);
>> + */
> 
> This commented out code is odd.
> Shouldn't you check if the user asked for ID match and return an error?

I think I'll drop the comment.

-- 
cheers,
-roger