Re: [PATCH v3 02/18] nvmet-fcloop: replace kref with refcount

[Hannes Reinecke]

On 4/2/25 16:03, Daniel Wagner wrote:
> On Tue, Mar 18, 2025 at 11:56:50AM +0100, Hannes Reinecke wrote:
> > On 3/18/25 11:39, Daniel Wagner wrote:
> > > The kref wrapper is not really adding any value ontop of refcount. Thus
> > > replace the kref API with the refcount API.
> > >
> > > Signed-off-by: Daniel Wagner <wagi@xxxxxxxxxx>
> > > ---
> > >    drivers/nvme/target/fcloop.c | 37 +++++++++++++------------------------
> > >    1 file changed, 13 insertions(+), 24 deletions(-)
> > Can you split this in two, one for the nport and one for fcpreq?
> > That way it's easier to follow what has been modified.
>
> Do you still want me to split the patch? You and Christoph have sent the
> Reviewed-by tag after this review.

Ah, no, Don't bother.

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxx                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich