Re: [PATCH 1/5] dt-bindings: iio: adc: ad7380: add AD7389-4

From: David Lechner
Date: Wed Apr 02 2025 - 10:39:58 EST


On 4/2/25 3:25 AM, Krzysztof Kozlowski wrote:
> On Tue, Apr 01, 2025 at 05:50:08PM -0500, David Lechner wrote:
>> Add compatible and quirks for AD7389-4. This is essentially the same as
>> AD7380-4 but instead of having no internal reference, it has no external
>> reference voltage supply.
>
> So neither refio nor refin, but your schema says:
>
>> + then:
>> + properties:
>> + refio-supply: false
>
> So what about refin, which is also external reference?

This is already handled by the existing if statement:

- if:
properties:
compatible:
enum:
- adi,ad7380-4
- adi,adaq4370-4
- adi,adaq4380-4
- adi,adaq4381-4
then:
properties:
refio-supply: false
required:
- refin-supply
else:
properties:
refin-supply: false