Re: [PATCH] coresight: Break to error handler if connection can't be made

From: Leo Yan
Date: Wed Apr 02 2025 - 10:56:09 EST


On Wed, Apr 02, 2025 at 02:07:59PM +0100, James Clark wrote:
> Change the return to a break so that the of_node_put()s in the error
> handler are hit on failure.
>
> Fixes: 3d4ff657e454 ("coresight: Dynamically add connections")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-arm-kernel/3b026b3f-2cb2-49ef-aa20-8b14220f5324@stanley.mountain/
> Signed-off-by: James Clark <james.clark@xxxxxxxxxx>

Reviewed-by: Leo Yan <leo.yan@xxxxxxx>