Re: [PATCH v5 3/3] mm/mempolicy: Support memory hotplug in weighted interleave

[Gregory Price]

On Wed, Apr 02, 2025 at 05:41:57PM +0200, Oscar Salvador wrote:
> 
> Yes, this callback will be called whenever {online,offline}_pages succeeds, but
> status_change_nid will be != NUMA_NO_NODE IFF the node state changes.
> And you already have the check
> 
>  if (nid < 0)
>     goto out
> 
> at the beginning, which means that all {offline,online}_pages operation that
> do not carry a numa node state change will be filtered out there.
> 
> Makes sense, or am I missing something?
>

Ah, you're quite right.  That was difficult to see on the surface, so
the check in fact superfluous.  No need for an extra version, can just
add a patch to squash and drop it.

~Gregory