Re: [PATCH] media: i2c: Add OV05C camera sensor driver

[Nirujogi, Pratap]

Hi Laurent,

Thanks for your response.

Thanks,
Pratap

On 4/1/2025 8:18 PM, Laurent Pinchart wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Hello Pratap,
>
> On Fri, Mar 28, 2025 at 06:10:41PM -0400, Nirujogi, Pratap wrote:
> > Hi Laurent,
> >
> > Thanks for reviewing and extremely sorry for the delayed response. We
> > have submitted V2 patch based on your review feedback.
> >
> > Can you please help to review latest V2 patch and let us know your feedback.
>
> Sure. It will take a bit of time though, as my review backlog is big.

Thanks for notifying us.

> Please see below for additional comments.
>
> > On 2/28/2025 12:35 PM, Laurent Pinchart wrote:
> > > Hi Pratap,
> > >
> > > Thank you for the patch.
> > >
> > > A few assorted comments to start with, I'll try to do a more in-depth
> > > review later.
> > >
> > > On Fri, Feb 28, 2025 at 11:53:12AM -0500, Pratap Nirujogi wrote:
> > > > Add driver for OmniVision 5.2M OV05C10 sensor. This driver
> > > > supports only the full size normal 2888x1808@30fps 2-lane
> > > > sensor profile.
> > >
> > > What have you tested this driver with ? I see no OF device ID or ACPI
> > > device ID.
> >
> > We have tested this driver on the "AMD RYZEN AI MAX PRO 385 w/ Radeon
> > 8050S" target supporting ISP HW v4.1. OMNI5C10 is ACPI HID for this
> > sensor on the target.
>
> That's interesting. Do you have plans to post a driver for the ISP ?
yes, we are planning to post the ISP driver patches once the dependent 
platform / sensor / i2c patches gets finalized after review.

> > > Please provide a v4l2-compliance report.
> >
> > Please refer the attached screenshot for the v4l2-compliance test
> > report. This test is ran with V2 patch. Fixed some of the compliance
> > test failures on V1 and ensured it is 100% compliant for the supported
> > IOCTLS.
>
> Could you please post the v4l2-compliance report in a reply to v2, in
> text format instead of a screenshot ?
Sure, will share the report in text format in response to V2.

> > > > Signed-off-by: Pratap Nirujogi <pratap.nirujogi@xxxxxxx>
> > > > ---
> > > >    drivers/media/i2c/Kconfig  |   10 +
> > > >    drivers/media/i2c/Makefile |    1 +
> > > >    drivers/media/i2c/ov05c.c  | 1031 ++++++++++++++++++++++++++++++++++++
>
> [snip]
>
> --
> Regards,
>
> Laurent Pinchart