Re: [PATCH 0/5] Add support for Battery Status & Battery Caps AMS in TCPM

[Amit Sunil Dhamne]

On 3/21/25 12:51 AM, Krzysztof Kozlowski wrote:
> On 20/03/2025 22:11, Amit Sunil Dhamne wrote:
> > On 3/16/25 9:52 AM, Krzysztof Kozlowski wrote:
> > > On 15/03/2025 01:49, Amit Sunil Dhamne wrote:
> > > > Hi Krzysztof,
> > > >
> > > > Thanks for the review!
> > > >
> > > > On 3/13/25 1:50 AM, Krzysztof Kozlowski wrote:
> > > > > On Wed, Mar 12, 2025 at 04:42:00PM -0700, Amit Sunil Dhamne wrote:
> > > > > > Support for Battery Status & Battery Caps messages in response to
> > > > > > Get_Battery_Status & Get_Battery_Cap request is required by USB PD devices
> > > > > > powered by battery, as per "USB PD R3.1 V1.8 Spec", "6.13 Message
> > > > > > Applicability" section. This patchset adds support for these AMSes
> > > > > > to achieve greater compliance with the spec.
> > > > > Which board uses it? I would be happy to see that connection between
> > > > > batteries and USB connector on the schematics of some real device. How
> > > > > does it look like?
> > > > Any board that uses a USB Type-C connector that supplies power into or
> > > If you keep responding like this, you will got nowhere, so let me
> > > re-iterate:
> > >
> > > Which upstream DTS (or upstream supported hardware) is going to use this
> > > binding, so I can see how you are going to implement it there in the
> > > entire system?
> > This is for maxim,max33359 Type-C controller.
> Stop deflecting the questions. max33359 is not a board. I already asked
> two times.
>
> Apparently admitting "no upstream users" is impossible, so let's state
> the obvious:
>
> There are no upstream users of this.

max33359 controller has an upstream user i.e., gs101-oriole (Pixel 6) 
board. Totally agree that at the moment there are no upstream 
devices/drivers for the Fuel Gauge (that my patchset has a dependency 
on) in gs101-oriole board. gs101-oriole uses max77759 fuel gauge device. 
I see that there's an effort for upstreaming it 
(https://lore.kernel.org/all/20250102-b4-gs101_max77759_fg-v2-0-87959abeb7ff@xxxxxxxxxxxx/). 
I will mark my patches as dependent on it + demonstrate the relationship 
of the devices in the gs101-oriole board. Hope that's okay?


Thanks,

Amit

> > This would property would have been present for the connector present in
> > the typec device for gs101-oriole board (that uses the max33359
> > controller).
>
> But it is not.
>
>
> > However, I will be exploring existing bindings to describe the
> > relationship for now.
> >
> > > > out of a battery while operating in sink or source mode respectively.
> > > > The VBUS is connected to the (battery + buck boost IC's CHGin/Vin) or a
> > > > companion IFPMIC connected to a battery.  In our board we have USB
> > > > Connector <-> IFPMIC <-> Battery.
> > > Which board is that?
> > gs101-oriole board.
>
> Then why this is not used? The board was released some years ago, so I
> do not see a problem in using it.
>
> Best regards,
> Krzysztof