Re: [PATCH RFC v2 7/7] iio: ti-adc128s052: Drop variable vref

[Matti Vaittinen]

On 02/04/2025 23:49, David Lechner wrote:
> On 4/2/25 1:10 AM, Matti Vaittinen wrote:
> > According to Jonathan, variable reference voltages are very rare. It is
> > unlikely it is needed, and supporting it makes the code a bit more
> > complex.
>
> There is also around 60 other drivers where we could do something like this
> in case anyone is bored. :-p
>
> > Simplify the driver and drop the variable vref support.
> >
> > Suggested-by: Jonathan Cameron <jic23@xxxxxxxxxx>
> > Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> > ---
> > Revision History:
> >   v2:
> >    - New patch
> > ---
> >   drivers/iio/adc/ti-adc128s052.c | 29 ++++++-----------------------
> >   1 file changed, 6 insertions(+), 23 deletions(-)
> >
> > diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
> > index 0f93c6266527..0bfe4e558c69 100644
> > --- a/drivers/iio/adc/ti-adc128s052.c
> > +++ b/drivers/iio/adc/ti-adc128s052.c
> > @@ -29,13 +29,12 @@ struct adc128_configuration {
> >   struct adc128 {
> >   	struct spi_device *spi;
> >   
> > -	struct regulator *reg;
> >   	/*
> >   	 * Serialize the SPI 'write-channel + read data' accesses and protect
> >   	 * the shared buffer.
> >   	 */
> >   	struct mutex lock;
> > -
> > +	int vref;
>
> Units in the name are helpful: vref_uv.
>
> Could also consider doing division in probe and storing vref_mv instead
> since we never use the microvolts part.

Ah, thanks for the suggestions. I agree with both.

> >   	union {
> >   		__be16 rx_buffer;
> >   		u8 tx_buffer[2];

Yours,
	-- Matti