RE: linux-next: build warning after merge of the amdgpu tree

[Kaszewski, Dominik]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Stephen,

I have sent out a patch adding a missing semicolon a month ago. I did not get any notification that it got merged, I am not familiar with AMD's upstreaming process.

+@Pillai, Aurabindo

Best regards,
Dominik Kaszewski
Senior Software Engineer
SW - Display NPI

-----Original Message-----
From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Sent: Thursday, April 3, 2025 8:02 AM
To: Kaszewski, Dominik <Dominik.Kaszewski@xxxxxxx>
Cc: Alex Deucher <alexdeucher@xxxxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Linux Next Mailing List <linux-next@xxxxxxxxxxxxxxx>
Subject: Re: linux-next: build warning after merge of the amdgpu tree

Hi Dominik,

On Wed, 19 Mar 2025 09:38:50 +0000 "Kaszewski, Dominik" <Dominik.Kaszewski@xxxxxxx> wrote:
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi,
>
> I don't understand this warning, the enum it cannot find has been introduced in the same commit immediately below:
>
> +       /**
> +        * @DC_HDCP_LC_ENABLE_SW_FALLBACK If set, upon HDCP Locality Check FW
> +        * path failure, retry using legacy SW path.
> +        */
> +       DC_HDCP_LC_ENABLE_SW_FALLBACK = 0x100000,
>
> Could it perhaps be about the missing colon before "If set"?

Yes, probably could be.

> -----Original Message-----
> From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Sent: Wednesday, March 19, 2025 10:35 AM
> To: Alex Deucher <alexdeucher@xxxxxxxxx>
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Kaszewski, Dominik <Dominik.Kaszewski@xxxxxxx>; Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Linux Next Mailing List <linux-next@xxxxxxxxxxxxxxx>
> Subject: linux-next: build warning after merge of the amdgpu tree
>
> Hi all,
>
> After merging the amdgpu tree, today's linux-next build (htmldocs) produced this warning:
>
> drivers/gpu/drm/amd/include/amd_shared.h:369: warning: Incorrect use of kernel-doc format:          * @DC_HDCP_LC_ENABLE_SW_FALLBACK If set, upon HDCP Locality Check FW
> drivers/gpu/drm/amd/include/amd_shared.h:369: warning: Incorrect use of kernel-doc format:          * @DC_HDCP_LC_ENABLE_SW_FALLBACK If set, upon HDCP Locality Check FW
> drivers/gpu/drm/amd/include/amd_shared.h:373: warning: Enum value 'DC_HDCP_LC_ENABLE_SW_FALLBACK' not described in enum 'DC_DEBUG_MASK'
>
> Introduced by commit
>
>   84ff5895399c ("drm/amdgpu: Add debug masks for HDCP LC FW testing")

So, I am still seeing this warning and that commit is now in Linus' tree.

--
Cheers,
Stephen Rothwell