RE: [PATCH v3 0/3] Add driver for AD3530R and AD3531R DACs

[Paller, Kim Seer]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Thursday, April 3, 2025 2:44 PM
> To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen
> <lars@xxxxxxxxxx>; Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>;
> Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>;
> Conor Dooley <conor+dt@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 0/3] Add driver for AD3530R and AD3531R DACs
> 
> [External]
> 
> On Thu, Apr 03, 2025 at 01:33:54PM +0800, Kim Seer Paller wrote:
> > The AD3530/AD3530R (8-channel) and AD3531/AD3531R (4-channel) are
> > low-power, 16-bit, buffered voltage output DACs with software-
> > programmable gain controls, providing full-scale output spans of 2.5V
> > or 5V for reference voltages of 2.5V. These devices operate from a
> > single 2.7V to 5.5V supply and are guaranteed monotonic by design. The "R"
> > variants include a 2.5V, 5ppm/°C internal reference, which is disabled
> > by default.
> >
> > The AD3531R/AD3531 is not yet released, so the only available
> > datasheet for now is the AD3530R/AD3530. The only differences between
> > the two is the number of channels, and register addresses of some registers.
> >
> > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> > ---
> > Changes in v3:
> > - Drop ABI docs.
> >
> > Bindings:
> > - Drop reviewer's tag.
> 
> Why? Explain why you are dropping.

I introduce modifications that might require re-review of the updated implementation
(e.g, adding io-channels property, switching to unevaluatedProperties: false, and adding
non-r variants to the compatible list). Is the tag still applicable?

> 
> Best regards,
> Krzysztof