RE: [PATCH v3 2/3] dt-bindings: iio: dac: Add adi,ad3530r.yaml

[Paller, Kim Seer]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Thursday, April 3, 2025 3:02 PM
> To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen
> <lars@xxxxxxxxxx>; Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>;
> Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>;
> Conor Dooley <conor+dt@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 2/3] dt-bindings: iio: dac: Add adi,ad3530r.yaml
> 
> [External]
> 
> On 03/04/2025 08:59, Paller, Kim Seer wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> >> Sent: Thursday, April 3, 2025 2:44 PM
> >> To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx>
> >> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen
> >> <lars@xxxxxxxxxx>; Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>;
> >> Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>;
> >> Conor Dooley <conor+dt@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx; linux-
> >> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> >> Subject: Re: [PATCH v3 2/3] dt-bindings: iio: dac: Add adi,ad3530r.yaml
> >>
> >> [External]
> >>
> >> On Thu, Apr 03, 2025 at 01:33:56PM +0800, Kim Seer Paller wrote:
> >>> Document the AD3530/AD3530R (8-channel) and AD3531/AD3531R (4-
> >> channel)
> >>> low-power, 16-bit, buffered voltage output DACs with software-
> >>> programmable gain controls. They provide full-scale output spans of
> >>> 2.5V or 5V for reference voltages of 2.5V. These devices operate on a
> >>> single 2.7V to 5.5V supply and are guaranteed to be monotonic by design.
> >>> The "R" variants include a 2.5V, 5ppm/°C internal reference, which is
> >>> disabled by default.
> >>>
> >>> Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> >>> ---
> >>>  .../devicetree/bindings/iio/dac/adi,ad3530r.yaml   | 99
> >> ++++++++++++++++++++++
> >>>  MAINTAINERS                                        |  7 ++
> >>>  2 files changed, 106 insertions(+)
> >>
> >> You got report about error in v2, which you did not respond to.
> >>
> >> You send v3... with same error. I don't understand this.
> >
> > I'm not sure, but based on the information provided, the errors might be
> > unrelated to the driver, or I might have missed something.
> 
> It's your job to respond to errors one way or another (unless there are
> obviously false positives). Ignoring them means this is marked as
> "changes requested".

My bad, I'll take note of that. I think the bindings error reported in v3 is
still unrelated to the current changes.

> 
> Best regards,
> Krzysztof