Re: [PATCH v1 1/1] media: raspberrypi: rp1-cfe: Remove (explicitly) unused header

[Tomi Valkeinen]

Hi,

On 31/03/2025 10:21, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
>
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>   drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> index 69a5f23e7954..fcadb2143c88 100644
> --- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> +++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> @@ -12,7 +12,6 @@
>   #include <linux/device.h>
>   #include <linux/dma-mapping.h>
>   #include <linux/err.h>
> -#include <linux/fwnode.h>
>   #include <linux/init.h>
>   #include <linux/interrupt.h>
>   #include <linux/io.h>

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>

 Tomi