Re: [PATCH] IPC MUX: Add error handling for ipc_mux_dl_acb_send_cmds().

From: Johannes Berg
Date: Thu Apr 03 2025 - 04:29:36 EST


On Thu, 2025-04-03 at 16:24 +0800, Wentao Liang wrote:
> The ipc_mux_dl_acbcmd_decode() calls the ipc_mux_dl_acb_send_cmds(),
> but does not report the error if ipc_mux_dl_acb_send_cmds() fails.
> This makes it difficult to detect command sending failures. A proper
> implementation can be found in ipc_mux_dl_cmd_decode().
>
> Add error reporting to the call, logging an error message using dev_err()
> if the command sending fails.
>
> Fixes: 1f52d7b62285 ("net: wwan: iosm: Enable M.2 7360 WWAN card support")

That should've given you a hint for your own patch's subject :)

johannes