Re: [PATCH v3 2/2] regulator: adp5055: Add driver for adp5055

From: Mark Brown
Date: Thu Apr 03 2025 - 07:09:51 EST


On Thu, Apr 03, 2025 at 10:43:11AM +0800, Alexis Czezar Torreno wrote:

> +static int adp5055_is_enabled(struct regulator_dev *rdev)
> +{
> + struct adp5055 *adp5055 = rdev_get_drvdata(rdev);
> + int id = rdev_get_id(rdev);
> + int val;
> +
> + if (adp5055->en_mode_software)
> + return regulator_is_enabled_regmap(rdev);
> +
> + val = gpiod_get_value_cansleep(adp5055->en_gpiod[id]);
> +
> + return val;
> +};

This is absolutely standard enable GPIO support, just let the core
handle everything. Otherwise this looks fine.

Attachment: signature.asc
Description: PGP signature