Re: [PATCH] serial: 8250: fix panic due to PSLVERR

[Andy Shevchenko]

On Thu, Apr 03, 2025 at 02:03:58PM +0206, John Ogness wrote:
> On 2025-04-03, Yunhui Cui <cuiyunhui@xxxxxxxxxxxxx> wrote:
> > When the PSLVERR_RESP_EN parameter is set to 1, the device generates
> > an error response if an attempt is made to read an empty RBR (Receive
> > Buffer Register) while the FIFO is enabled.
> >
> > In serial8250_do_startup, calling serial_port_out(port, UART_LCR,
> > UART_LCR_WLEN8) triggers dw8250_check_lcr(), which invokes
> > dw8250_force_idle() and serial8250_clear_and_reinit_fifos(). The latter
> > function enables the FIFO via serial_out(p, UART_FCR, p->fcr).
> > Execution proceeds to the dont_test_tx_en label:
> > ...
> > serial_port_in(port, UART_RX);
> > This satisfies the PSLVERR trigger condition.
> >
> > Because another CPU(e.g., using printk) is accessing the UART (UART
> > is busy), the current CPU fails the check (value & ~UART_LCR_SPAR) ==
> > (lcr & ~UART_LCR_SPAR), causing it to enter dw8250_force_idle().
> 
> Didn't this[0] patch resolve this exact issue?

I see it applied (in v6.0), but version in the traceback seems from v6.12.
I think this is about race condition so only locking parts should suffice.

> [0] https://lore.kernel.org/lkml/20220713131722.2316829-1-vamshigajjela@xxxxxxxxxx

-- 
With Best Regards,
Andy Shevchenko