Re: [PATCH v3 07/17] x86/apic: Support LAPIC timer for Secure AVIC

[Thomas Gleixner]

On Tue, Apr 01 2025 at 17:06, Neeraj Upadhyay wrote:
> In addition, add a static call for apic's update_vector() callback,
> to configure ALLOWED_IRR for the hypervisor to inject timer interrupt
> using LOCAL_TIMER_VECTOR.

How is this static call related to the timer vector? It just works with
the conditional callback. apic_update_vector() is not used in a
hotpath.

Even if there is a valid reason for the static call, why is this not
part of the patch, which adds the update_vector() callback?

It's well documented that you should not do random unrelated things in
patches.

You really try hard to make review a pain.

Thanks,

        tglx