Re: [PATCH] Documentation/x86: Clarify naming of CPU features for /proc/cpuinfo
From: Borislav Petkov
Date: Thu Apr 03 2025 - 08:17:58 EST
On Thu, Apr 03, 2025 at 03:13:08PM +0530, Naveen N Rao (AMD) wrote:
> Commit 78ce84b9e0a5 ("x86/cpufeatures: Flip the /proc/cpuinfo appearance
> logic") changed how CPU feature names should be specified. Update
> document to reflect the same.
>
> Signed-off-by: Naveen N Rao (AMD) <naveen@xxxxxxxxxx>
> ---
> Documentation/arch/x86/cpuinfo.rst | 42 +++++++++---------------------
> 1 file changed, 13 insertions(+), 29 deletions(-)
>
> diff --git a/Documentation/arch/x86/cpuinfo.rst b/Documentation/arch/x86/cpuinfo.rst
> index 6ef426a52cdc..fecdc36e02a1 100644
> --- a/Documentation/arch/x86/cpuinfo.rst
> +++ b/Documentation/arch/x86/cpuinfo.rst
> @@ -124,37 +124,21 @@ also defined in cpufeatures.h.
> Naming of Flags
> ===============
>
> -The script arch/x86/kernel/cpu/mkcapflags.sh processes the
> -#define X86_FEATURE_<name> from cpufeatures.h and generates the
> -x86_cap/bug_flags[] arrays in kernel/cpu/capflags.c. The names in the
This is not the patch I saw in internal review. The script still processes
cpufeatures.h
Please go through all the text you're changing and verify you're *actually*
doing the right thing.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette