Re: [PATCH v1 4/5] gpiolib: acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup

[Mika Westerberg]

On Thu, Apr 03, 2025 at 02:04:04PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 03, 2025 at 01:35:06PM +0300, Mika Westerberg wrote:
> > On Wed, Apr 02, 2025 at 03:21:19PM +0300, Andy Shevchenko wrote:
> > > Some of the contents of struct acpi_gpio_lookup repeats what we have
> > > in the struct acpi_gpio_params. Reuse the latter in the former.
> 
> > > +	struct acpi_gpio_params par;
> > 
> > params is better name
> 
> It's been already used elsewhere in the code. Do you want renaming there as
> well for consistency's sake?

If there is no problem confusing these then no need to rename anything
else.

> 
> ...
> 
> > >  	struct acpi_gpio_lookup *lookup = data;
> > > +	struct acpi_gpio_params *par = &lookup->par;
> > 
> > These are not changed I guess so can this be const?
> 
> They are, see below. So the answer, it can't.

Okay then nevermind.