Re: [PATCH -tip v3] x86/idle: Use MONITOR and MWAIT mnemonics in <asm/mwait.h>

[Borislav Petkov]

On Thu, Apr 03, 2025 at 02:50:45PM +0200, Uros Bizjak wrote:
>  static __always_inline void __monitor(const void *eax, u32 ecx, u32 edx)
>  {
> -	/* "monitor %eax, %ecx, %edx;" */
> -	asm volatile(".byte 0x0f, 0x01, 0xc8;"
> -		     :: "a" (eax), "c" (ecx), "d"(edx));
> +	/* Use the instruction mnemonic with implicit operands, as the LLVM
> +	   assembler fails to assemble the mnemonic with explicit operands. */

mingo, pls fix up that comment style and in the other spot when applying.

Other than that:

Acked-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette